#163 Fix wrong cancel job conditional (Attempt 3)
Merged by zuul. Opened by lecris.
lecris/zuul-distro-jobs cancel-scratch-build  into  master

Download 163.patch

So the caching worked, but I found I was using a wrong logic there. For reference:

  • Test build that should have been canceled
2025-09-09 16:06:09.636785 | TASK [fedpkg-build-cleanup : Check post-run variables]
2025-09-09 16:06:09.688079 | task_id = 136951410
2025-09-09 16:06:09.688268 | koji_task_returned = not defined
2025-09-09 16:06:09.688298 | zuul_success = False
2025-09-09 16:06:09.693438 | 
2025-09-09 16:06:09.693525 | TASK [fedpkg-build-cleanup : Get the current state of Koji task]
2025-09-09 16:06:09.955851 | container | skipping: Conditional result was False
  • Successful build: https://fedora.softwarefactory-project.io/zuul/build/9aee5f42637f4198adb432aaddcfd8aa/console
task_id = 136948519
koji_task_returned = True
zuul_success = True
(post-run skipped)
  • Failed build: https://fedora.softwarefactory-project.io/zuul/build/c758833b9e484eb4a58dbf01a832be06/console
task_id = 136948028
koji_task_returned = True
zuul_success = False
(the conditional passed here, but there were other parts that skipped the cancellation)

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/f43afe6e29e44990b1e1d35ac55a3710

Metadata Update from @mvadkert:
- Pull-request tagged with: gateit

Build succeeded (gate pipeline).
https://fedora.softwarefactory-project.io/zuul/buildset/0b85a4a630e142a58e80a5add6aa7ff6

Pull-Request has been merged by zuul

Metadata