#277 common: Add readonly sysroot migration unit and script
Merged by siosm. Opened by siosm.
Unknown source main

Download 277.patch

Add unit and corresponding script to migrate existing systems to read
only sysroot.

See: https://fedoraproject.org/wiki/Changes/Silverblue_Kinoite_readonly_sysroot
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2060976

CC @tpopela @walters @dustymabe @jlebon

I've tested the script but still need to test the full setup with the service unit.

This will also be simpler once we have https://github.com/coreos/rpm-ostree/issues/3603 or https://github.com/ostreedev/ostree/issues/2590.

rebased onto 019959af31e1464e8c3b6f6b0dbc2170fd2a3817

rebased onto fa7e7084f09e1eb3ab5214754ca01af1cd941ce7

rebased onto 96f5dd459778bd26fdbbc9efec5293ea8bd00d41

This is now ready for review and the changes required have landed in ostree 2022.5 which is in rawhide now.

I've manually tested the script in a Silverblue VM.

ConditionPathIsReadWrite=/sysroot

perhaps?

I think we also want
RemainAfterExit=yes
see https://github.com/ostreedev/ostree/pull/1697

As of right now nothing else is ordering against this unit, but you never know.

Anaconda PR in https://github.com/rhinstaller/anaconda/pull/4240

rebased onto 861016b1abb8954a6ad01017cefd17f42c576901

Thanks Colin! Updated

Minor: the convention is Title Case for systemd units. Maybe something like:

Fedora Silverblue Read-Only Sysroot Migration

?

Are we missing Type=oneshot here?

Could we name this script more something like fedora-silverblue-sysroot-readonly? The current name makes it seem like it's owned by OSTree.

condition

Looks sane to me overall!

rebased onto f810ca44f15f65edf6957cefa6691e1fc43b1c3a

Updated. Thanks Jonathan!

rebased onto 20f68980328e4250316712ab8fccb2c1765e4bbd

rebased onto b87ec3ccd0ccc59982d1f131dc8bc15c2bcfe4d8

Merging this one before we branch.

Pull-Request has been merged by siosm

Metadata