PR#65: exclude conf/settings.py from published tarballs -

waiverdb

#65 exclude conf/settings.py from published tarballs

Merged Jun 23, 2017 by dcallagh. Opened Jun 23, 2017 by dcallagh.

dcallagh/waiverdb manifest-no-conf-glob into master

dcallagh commented Jun 23, 2017

The waiverdb-0.2.1 tarball I published accidentally included a 0-byte
conf/settings.py because that file was (uncommitted) in my working tree
when I built the tarball. Moreover I didn't notice because we explicitly
gitignore'd that file because we expect everyone to have to it in
their working tree.

So let's ensure that the setuptools manifest won't pick it up in future.
A nicer solution might be to switch to setuptools-git to ensure the
tarball never includes random uncommitted junk in it...

mjia commented Jun 23, 2017

:thumbsup:

rebased

Jun 23, 2017

dcallagh commented Jun 23, 2017

Trying again... First version of the patch didn't actually work (there is an implicit inclusion for *.py).

ralph commented Jun 23, 2017

:+1:

Pull-Request has been merged by dcallagh

Jun 23, 2017