PR#294: FIX W504 warning: Line break occurred after a binary operator -

waiverdb

#294 FIX W504 warning: Line break occurred after a binary operator

Merged Mar 5, 2019 by gnaponie. Opened Mar 4, 2019 by rayson.

rayson/waiverdb fix-w504 into master

rayson commented Mar 4, 2019

After upgrading C3I Jenkins slave pod from Fedora 28 to 29,
C3I pipeline builds for waiverdb fails with a Flake8 warning:
W504 line break after binary operator.

This happens because of a updated PEP 8 rule, which
recommends that line breaks should occur before the binary operator
because it keeps all operators aligned.
However both W503 and W504 are enforced when all warnings are configured.

This pull-request eliminates the warning by following the new rule and ignoring W503.

rayson commented Mar 4, 2019

@lholecek @ralph Can you take a look?

mikeb commented Mar 4, 2019

+1 I don't have strong feelings on this style one way or another, and flake8 was ridiculous to try to enforce both. This solution looks reasonable.

fivaldi commented Mar 5, 2019

:thumbsup:

gnaponie commented Mar 5, 2019

Looks good

gnaponie commented Mar 5, 2019

Commit 234455f6 fixes this pull-request

Pull-Request has been merged by gnaponie