waiverdb

#275 (Build)Requires for Prometheus monitoring, see PR#274
Merged by mprahl. Opened by fivaldi.
fivaldi/waiverdb fivaldi_prereqs_for_prometheus_monitoring  into  master

Download 275.patch

This is prerequisite for PR#274. The next step is to build ten Jenkins slave image with these new deps and then continue with the PR#274.

Why is this necessary? six isn't part of the codebase.

Edit: I see that in PR #275 you added this. Shouldn't it be part of the Requires too then to not have to rely on other packages pulling it in?
Edited by mprahl

rebased onto dad10c731866e97af14a397567c8bf967cd05d0a

Why is this necessary? six isn't part of the codebase

Sounds like python3-prometheus_client is not specifying all the deps it needs? If so, we should probably fix that.

@lucarval it's a bit confusing since the PRs are separate, but it seems that it's only used in the tests, which is why it is a BuildRequire.

This looks fine. I'll merge it.

Pull-Request has been merged by mprahl

The CI failed also here, can we fix that?

ref: https://jenkins-waiverdb-test.cloud.paas.upshift.redhat.com/job/waiverdb-test/job/waiverdb-test-waiverdb-dev/167/console 

14:03:07 [Branch RPM] error: Failed build dependencies:
14:03:07 [Branch RPM]   python3-prometheus_client is needed by waiverdb-0.13.1-0.git.6.dad10c7.fc28.noarch

It looks like we may need to update the Jenkins image to include this dependency? I don't think that's getting installed automatically based on spec file.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.