#132 Fixes for the change from SQLite to PostgreSQL
Merged by ralph. Opened by gnaponie.
gnaponie/waiverdb switch-to-postgres  into  master

Download 132.patch
  • Removed a warning in the tests adding psycopg2-binary to
    the requirements.txt.
  • Removed code that was used only for SQLite compatibility
    (no more needed since we moved to PostgreSQL).

Ah, don't pin the version unless absolutely necessary. Just psycopg2-binary will be fine.

rebased onto 80f65b008f0fee80734f53c39eda4be7b559b188

It should be ok now.
Added also the requirement of psycopg2 in the spec file

Pull-Request has been merged by ralph

That would be a -1 from me... I am guessing that weird psycopg2-binary requirement is not provided by the normal python2-psycopg2 package in Fedora, and thus this is yet another case where pip install'ing dependencies is incompatible with dnf install'ing them.

We should really, really just not do pip install, especially not for compiled stuff like psycopg2. Always just install the distribution package instead.

The comment is kind of irrelevant. The batch_alter_table is still preferable, even on Postgres, because it issues a single ALTER TABLE instead of three separate ones. So it's less work for the database.

Also there is no point in changing existing migrations because we have to assume that some/all deployments have already run them anyway.

Metadata