waiverdb

#105 Tag successful builds with "master".
Merged by dcallagh. Opened by ralph.
tag-success  into  master

Download 105.patch

We were looking at deploying the "latest" tag to open.paas/waiverdb-stg, but we
didn't want to conflate "latest" usable with "latest" passed CI.

The attempt here is to create an automatic tracking tag for everything that has
merged into master and passed CI, called master. We could have our openshift
staging environments pull from here while we instead have our openshift prod
environments pull from a manually curated latest tag.

How does that sound? :)

Hm - does anyone know how to lint this before it gets merged?

@ralph, https://jenkins.io/doc/book/pipeline/development/#linter

Or you could take my approach and just merge it, and then push a whole pile of fixup commits until it actually works in Jenkins... :-P

This idea sounds good though. Having a tag match the git master branch will be useful.

Should this maybe be .push('factory2/waiverdb:master') ?

Nope never mind. Found the docs for Image.push (obtusely you have to go to your Jenkins master's Pipeline syntax reference to see them...) and you have this right.

:+1:

I will hit the button on this and see how it goes in Jenkins... I can also push any fixups commits needed if it breaks :-)

Pull-Request has been merged by dcallagh

Oh I just realised... this step should probably be wrapped in a conditional to only happen on the master git branch. Same as the docs publishing step is currently.

That's because, if we (hopefully one day) get Jenkins running on pull requests before merge, we don't want those to be tagged in the registry. They can be pushed, but just not tagged.

It worked! :tada:

:beers:

Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.