From c0637efb9d06b0ba07312eb7b2b4e6eaea36c7f4 Mon Sep 17 00:00:00 2001
From: Lukas Holecek <hluk@email.cz>
Date: Nov 11 2021 06:30:20 +0000
Subject: Avoid redundant DB operations


---

diff --git a/resultsdb/controllers/api_v1.py b/resultsdb/controllers/api_v1.py
index 3205763..dbc84c1 100644
--- a/resultsdb/controllers/api_v1.py
+++ b/resultsdb/controllers/api_v1.py
@@ -325,7 +325,6 @@ def create_job():
     db.session.add(job)
     db.session.commit()
 
-    db.session.add(job)
     return jsonify(SERIALIZE(job)), 201
 
 
@@ -527,7 +526,6 @@ def create_result():
             # TODO: add configurable default "empty" URL
             testcase = Testcase(args['testcase_name'], "")
             db.session.add(testcase)
-            db.session.commit()
 
     outcome = args['outcome'].strip().upper()
     if outcome not in RESULT_OUTCOME:
@@ -566,8 +564,6 @@ def create_result():
     db.session.add(result)
     db.session.commit()
 
-    db.session.add(result)
-
     if app.config['MESSAGE_BUS_PUBLISH']:
         plugin = load_messaging_plugin(
             name=app.config['MESSAGE_BUS_PLUGIN'],
@@ -652,7 +648,6 @@ def create_testcase():
         # return jsonify({"message": e.message}), 400
         return jsonify({"message": "Testcase with this name already exists"}), 400
 
-    db.session.add(testcase)
     return jsonify(SERIALIZE(testcase)), 201
 
 
diff --git a/resultsdb/controllers/api_v2.py b/resultsdb/controllers/api_v2.py
index d1927e3..3910a17 100644
--- a/resultsdb/controllers/api_v2.py
+++ b/resultsdb/controllers/api_v2.py
@@ -314,7 +314,6 @@ def create_group():
     db.session.add(group)
     db.session.commit()
 
-    db.session.add(group)
     return jsonify(SERIALIZE(group)), 201
 
 
@@ -641,7 +640,6 @@ def create_result():
         testcase = Testcase(name=tc['name'])
     testcase.ref_url = tc.get('ref_url', testcase.ref_url)
     db.session.add(testcase)
-    db.session.commit()
 
     # args[groups] is a list of strings(uuid) or dicts(group object)
     #  when a group defined by the string is not found, new is created
@@ -663,7 +661,6 @@ def create_result():
             group.ref_url = grp.get('ref_url', group.ref_url)
 
             db.session.add(group)
-            db.session.commit()
             groups.append(group)
 
     result = Result(testcase, outcome, groups, args['ref_url'], args['note'])
@@ -698,7 +695,6 @@ def create_result():
     db.session.add(result)
     db.session.commit()
 
-    db.session.add(result)
     app.logger.debug("Created new result for testcase %s with outcome %s", testcase.name, outcome)
 
     if app.config['MESSAGE_BUS_PUBLISH']:
@@ -800,7 +796,6 @@ def create_testcase():
     db.session.add(testcase)
     db.session.commit()
 
-    db.session.add(testcase)
     return jsonify(SERIALIZE(testcase)), 201