#428 Reland "update to new bodhi library"
Merged by frantisekz. Opened by frantisekz.
non-legacy-bodhi  into  develop

Download 428.patch

This reverts commit 85c9537b5c4a3c1f484c0fc5860a388d02afeef2.

We now have python3-bodhi-client in F28 [0]

[0] https://src.fedoraproject.org/rpms/bodhi/pull-request/6

It builds fine, but unfortunately it breaks dev environment, because it can't be installed from pypi:
https://github.com/fedora-infra/bodhi/issues/2401#issuecomment-454456129

We need to wait until that's fixed.

rebased onto 1242f7e2fd5c8c881a2b864853433eeaa2b38842

rebased onto f227135a5e5879aa235216660b0f1868b9c27a4d

I've rebased this one.

@kparal One of the way forward would be to drop bodhi-client from requirements and let it be in dev env through site-packages. WDYT?

I don't have a strong opinion here. No task is currently using our bodhi directive, so we can easily wait until Bodhi devs make pypi work properly. OTOH I'm not opposed to making it a RPM requirement instead of Pypi requirement and resolve this. If you think we should do the latter, please update the PR, including a documentation change in Taskotron Development Guide (squash into a single commit). Also please note that dropping Fedora 28 support should not be part of this PR. Thanks.

rebased onto 73a793ef8513307071773fde51b4d4aaf2917348

rebased onto e5be061df872e0d26c8c393149bf117844d54a2d

Everything should be addressed now :)

Sorting isn't your forte, is it? :-D

configparser is now part of the standard Python3 library. Was something broken without this extra package?

Documentation! You get a :cookie: !

rebased onto 421cfde3a85701b0d58b369186bc66a153c022c1

Yeah, but since unsorted stuff triggers you it helps with keeping you awake while reading through the docs ;)

configparser is not needed, I ran the testsuite without that installed on F29 and F30.

The last weird warning that appears while running the tests is this:

/usr/lib/python3.7/site-packages/fedora/client/bodhi.py:48
  /usr/lib/python3.7/site-packages/fedora/client/bodhi.py:48: DeprecationWarning: fedora.client.bodhi has been deprecated. Please use bodhi.client.bindings instead.
    DeprecationWarning)

I have no idea where that comes from.

The warning is there because bodhi.client.bindings imports fedora.client.bodhi itself. Hahaha :D

LGTM. Please include

Merges: https://pagure.io/taskotron/libtaskotron/pull-request/428

inside the git commit message.

rebased onto 297f36c02b0cb4585cbc91abb2d5eb36090fd449

Commit 297f36c0 fixes this pull-request

Pull-Request has been merged by frantisekz

Pull-Request has been merged by frantisekz

Metadata