For ovirt-web-ui we need to have a possibility to set custom status on creation. So in this issue I added option to set custom status.
ovirt-web-ui
Could you look at lines 677-689 and copy that format for the transition. This way we can use the same function and have consistency. If you feel that it needs to be extracted to a function we can do that as well.
:+1: to Sid's comment, although the line numbers look a little off to me. @biakymet, it's the last stanza of _update_transition.
_update_transition
Can you just re-factory and re-use the entire _update_transition function?
The problem of refactoring _update_transition is that function is too specific, so it is better write own function for transition and than use it in _update_transition and in _create_jira_issue
_create_jira_issue
1 new commit added
Refactored status transition
You are using issue here. You will need to pass it in as a variable
Please add the appropriate docs, we use readthedocs so the format is very picky :( Would look like: """ The reason for the function.
:param type_of_object name_of_object: what_the_object_does
Overall looks good: 1. Can you change default_status -> default_transition (we use transition for another parameter so it would make sense to keep the name transition) (change function name + param in the config file) 2. Update the README
Can you change default_status -> default_transition (we use transition for another parameter so it would make sense to keep the name transition) (change function name + param in the config file)
In that case meaning of default_transition is not very clear, because word transition can mean any transition, so I prefer leave it as it is.
default_transition
2 new commits added
Refactored status transition and updated README
Added configuration for custom ticket status
LGTM, merging
Pull-Request has been merged by sidpremkumar
For
ovirt-web-uiwe need to have a possibility to set custom status on creation. So in this issue I added option to set custom status.