svrcore

#16 with-systemd should return ac_result no if pkg-config doesn't find headers.
Closed Opened by firstyear.

Closed
Reopen Issue

If you use --with-systemd on a non-systemd system, it should detect the lack of header files and set result no, instead of continuing and failing to build.

0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch

I would need to check Fedora packaging guidelines[1]
Because I am not sure whether you can rely on fact that systemd is part of build-root. It might be better to use BuidRequires: pkgconfig(systemd)

sh$ rpm -q --provides systemd | grep pkgconfig
pkgconfig(systemd) = 231
pkgconfig(udev) = 231

BTW what is a purpose of following ifdef:
+#ifdef HAVE_SYSTEMD
+#ifndef _WIN32

If I read condition right then it will be true for systems which has systemd and are not windows. Systemd is linux only so the 2nd ifdef is redundant.

[1] http://fedoraproject.org/wiki/Packaging:Guidelines

0001-Ticket-16-with-systemd-should-unset-have-systemd-if-.patch

Remove win32 define, and update buildrequires.

ACK,
works fine with fedora and freebsd

I almost every time forget that 389-team is used to keep autoconf generated files in git. So please do not forget regenerate them. It is required due to changes in m4/systemd.m4

I'm trying to get rid of them. See http://www.port389.org/docs/389ds/design/configure-artifacts.html

commit 2e8ffb5e5f0d4f0c1e6f6bd74d78cf8dc2d22de1
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 1.17 KiB | 0 bytes/s, done.
Total 8 (delta 7), reused 0 (delta 0)
To ssh://git@pagure.io/svrcore.git
ed490d1..2e8ffb5 master -> master

@firstyear changed the status to Closed
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.