PR#77: Stick to the pep8 style docker inventory -

standard-test-roles

#77 Stick to the pep8 style docker inventory

Closed Jan 18, 2018 by astepano. Opened Nov 1, 2017 by sturivny.

Unknown source master

sturivny commented Nov 1, 2017

Remove unused import.
Groome code to pep8 style.

astepano commented Nov 28, 2017

Formating shout be as follow:

    # Check for any additional arguments to include when starting docker
    # container

in VIM: ctrl-v, gq

astepano commented Nov 28, 2017

What is wrong with {0} ?

astepano commented Nov 28, 2017

Right indentation:

    cmd = ["/usr/bin/docker", "run", "--detach",
           "--cidfile={}".format(cidfile)] + extra_arg_list + [
               "--entrypoint=/bin/sh", image, "-c", "sleep 1000000"]

2 new commits added

Stick to the pep8 style docker inventory
Stick to the pep7 style docker inventory

Dec 1, 2017

rebased onto 15d87494e957015bc6024f6cafbac3cbd8b1a494

Dec 1, 2017

sturivny commented Dec 1, 2017

@astepano Updated PR,
so if you have free time welcome for review =)

sturivny commented Dec 1, 2017

What is wrong with {0} ?
{} without 0 it looks simlpy.

Pull-Request has been closed by astepano

Jan 18, 2018

Metadata

Assignee

None

Tags

No Tags

standard-test-roles

#77 Stick to the pep8 style docker inventory Closed Jan 18, 2018 by astepano. Opened Nov 1, 2017 by sturivny. Unknown source master

Metadata

#77 Stick to the pep8 style docker inventory

Closed Jan 18, 2018 by astepano. Opened Nov 1, 2017 by sturivny.

Unknown source master