standard-test-roles

#406 testing -device nvme requires serial
Closed by rmeggins. Opened by rmeggins.
rmeggins/standard-test-roles nvme-requires-serial  into  master

Download 406.patch

When testing to see if -device supports nvme, the ,serial= option
is required. Use a value of testing9999 to avoid collisions with
other values possibly in use.

Need to merge this asap as this is causing CI to blow up.

@nhosoi @spetros

This is now not working on el7 with qemu:

sh-4.2# echo quit | qemu-system-x86_64 -device virtio-scsi-pci -S -monitor stdio
(process:210): GLib-WARNING **: 03:48:31.408: gmem.c:489: custom memory allocation vtable not supported
QEMU 2.0.0 monitor - type 'help' for more information
(qemu) 
(qemu-system-x86_64:210): Gtk-WARNING **: 03:48:31.425: cannot open display: 
sh-4.2# echo $?
1

@merlinm @astepano @bgoncalv Why does the device lookup use this awkward method

echo quit | qemu-system-x86_64 -device $device -S -monitor stdio

which seems to be very qemu/kvm version dependent? Is there some reason we cannot just simply parse the output of qemu -device ? e.g.

sh-4.2# qemu-system-x86_64 -device ? 2>&1 | grep '"nvme"'
name "nvme", bus PCI, desc "Non-Volatile Memory Express"

? This method works on all versions of qemu that I have tested.

closing in favor of https://pagure.io/standard-test-roles/pull-request/407

Pull-Request has been closed by rmeggins
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.