PR#391: new scsi, nvme support for VM -

standard-test-roles

#391 new scsi, nvme support for VM

Merged Dec 9, 2020 by astepano. Opened Nov 18, 2020 by japokorn.

japokorn/standard-test-roles master-qcow_scsi_nvme_support into master

japokorn commented Nov 18, 2020

added support for SCSI and NVME into VM creation script
- storage role testing enhancement (https://github.com/linux-system-roles/storage)
- provision file now supports new 'drive' suboption 'interface'
- accepted values: 'virtio' (default), 'scsi', 'nvme'

astepano commented Nov 19, 2020

Looks good, I would ask to add a comment into git commit where do you plan to use it (package name), or why it is is required, maybe add some contacts.

rebased onto 2c6c82f747642ee25e6ac761e90e90ff138b0b1a

Nov 24, 2020

astepano commented Nov 25, 2020

@japokorn hi, I am ok to merge it . Please let me know when PR is ready for merge.
It would be good to get +1 from someone else. @msrb, @bgoncalv , @jimbair ?

bgoncalv commented Nov 26, 2020

lgtm

japokorn commented Nov 26, 2020

@astepano Ready. Thanks for the comments and review.

rebased onto 23a42178210135d9524e7b86be269821a75bb784

Dec 7, 2020

astepano commented Dec 8, 2020

pretty please pagure-ci rebuild

astepano commented Dec 8, 2020

@japokorn CI passed. Should I merge this PR? Is it ready?

japokorn commented Dec 9, 2020

@astepano Yes, you can merge it. Thanks.