#370 add support to archive logs using beakerlib functions
Merged by astepano. Opened by bgoncalv.
bgoncalv/standard-test-roles beakerlib-role  into  master

Download 370.patch

beakerlib provides rlBundleLogs and rlFileSubmit functions to store files

Add support so the usage of this function will save the files to artifacts

Related to https://pagure.io/standard-test-roles/issue/35

https://github.com/beakerlib/beakerlib/wiki/man

I would add some header with info:
Purpos: store any file at path.....
This scripts expects 2 env vars:
This script should be called in form: str-beakerlib-submit-log
Where - is path to ? What kind of path full or relative according to?

BEAKERLIB_COMMAND_SUBMIT_LOG - is absent in current master, who will use this VAR ? Maybe add this explanation to this file?

Plus add a note that must be file. (not directory).

No need to export

No need to export

rebased onto ccf4f02e57a1138dc6d8c5dc4717f88333fc6f67

@bgoncalv thank you! looks much better! Let's merge when CI passes.

Test doesn't check whether these submits actually submit the file(s). Nothing checks return codes (you could wrap the commands with rlRun) nor whether the files are actually present at the backup location.

for the test it is transparent where STR artifacts are stored, that's why we make sure the logs are actually saved on test runner.

https://pagure.io/standard-test-roles/pull-request/370#_4__17 :)

for the test it is transparent where STR artifacts are stored, that's why we make sure the logs are actually saved on test runner.
https://pagure.io/standard-test-roles/pull-request/370#_4__17 :)

I see. In that case just the wrapping in rlRun to make sure commands returned 0.

After discussion with @bgoncalv it seems that integrated test will fail anyway, on the previous step. @bgoncalv right? @jheger if you insist on rewriting test case please let me know.

Commit 6a39c532 fixes this pull-request

Pull-Request has been merged by astepano

Pull-Request has been merged by astepano

Metadata