standard-test-roles

#34 roles: More rigorous parsing of PASS/FAIL in beakerlib tests
Merged by merlinm. Opened by stefw.
stefw/standard-test-roles beakerlib-pass-fail-check  into  master

Download 34.patch

The parsing of PASS or FAIL status from a beakerlib test
output needs to be more rigorous, or tests with lines like
FAILED in their output will be triggered.

As noted at https://pagure.io/standard-test-roles/issue/32#comment-450692, false UNKNOWNs are now reported.

Perhaps it would help to prepend the more granular pass/fail logic to what was already there, maybe something line:

      if grep -q '\[ *FAIL *\]' "$logfile"; then
        echo "FAIL {{ item }}" >> {{ remote_artifacts }}/test.log
      elif grep -q '\[ *PASS *\]' "$logfile"; then
        echo "PASS {{ item }}" >> {{ remote_artifacts }}/test.log
      elif grep -q FAIL "$logfile"; then
        echo "FAIL {{ item }}" >> {{ remote_artifacts }}/test.log
      elif grep -q PASS "$logfile"; then
        echo "PASS {{ item }}" >> {{ remote_artifacts }}/test.log
      else
        echo "UNKNOWN {{ item }}" >> {{ remote_artifacts }}/test.log
      fi

Good idea. Done.

rebased

Tested, and that works much better now. Thanks.

Pull-Request has been merged by merlinm
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.