#210 makefile is not required for beakerlib role
Merged by astepano. Opened by bgoncalv.
bgoncalv/standard-test-roles fix-resolve-test-dependencies  into  master

Download 210.patch

beakerlib role should not fail If test case does not include Makefile.

I do not see anywhere these two list being used ...

what about informing here what is happening here (like skipping resolving test dependencies from Makefile)? not just silently ignoring?

They are used on roles/standard-test-beakerlib/tasks/main.yml

Do you think is needed? I believe this should be transparent to user... If you want sure it can be done :-)

I think this line is not necessary. Otherwise we need to check if above vars/facts are set.
Better to have them always set, to default empty list.
This is more flexible:

- include_role:
    name: str-common-pkgs
  vars:
    param_req_pkgs: "{{ makefile_pkgs_req1 | union(makefile_pkgs_req2) }}"

rebased onto ab1156e084e336a27513e5b57edc38f68779951c

rebased onto 082499907cb0f0808666e891efcafa2fcf47d577

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

Test CI passed.
PR looks good.
Thank you.

Commit a98e41bb fixes this pull-request

Pull-Request has been merged by astepano

Pull-Request has been merged by astepano

Metadata