standard-test-roles

#159 beakerlib role does not work on atomic host
Closed: SOLVED Opened by bgoncalv.

Closed: SOLVED
Reopen Issue

Since Commit#938db65 if test case has Makefile it will execute make run. Atomic host does not have make and therefore make run fails causing the test to be marked as failed.

  elif [ -d {{ item }} ]; then
    cd {{ item }}
    if [ -f Makefile ]; then
      make run
    elif [ -f runtest.sh ]; then
      /bin/sh -e ./runtest.sh
    else

There is a comment that Atomic Host has make:

https://pagure.io/standard-test-roles/issue/60#comment-467619

Anyway, thank you for the bug report.

Metadata Update from @astepano:
- Issue assigned to astepano

I've tested https://kojipkgs.fedoraproject.org/compose/rawhide/latest-Fedora-Rawhide/compose/AtomicHost/x86_64/images/Fedora-AtomicHost-Rawhide-20180326.n.0.x86_64.qcow2

# rpm -q make
package make is not installed

If Atomic host should have make then this is another bug :)

Fixed in 2b85f6c.

Metadata Update from @astepano:
- Issue close_status updated to: SOLVED
- Issue status updated to: Closed (was: Open)

@astepano thanks for the patch.
Note that which is not available on Fedora containers. We should add which as beakerlib requirements or if we do not want to install mode dependencies we could use something like rpm -q make to check if package is available.

@bgoncalv couldyou please try if works on Atomic /classic next code:

if [ -f Makefile ] && command -p -v make >/dev/null 2>&1; then

@astepano it looks good. It behaves well on Classic, Atomic and Container.

Updated at e808d4f
Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.