While writing integration tests for the Rust sigul client, I hit this sigul bug. Attempting to create a new key of type RSA fails on the server with:
[sigul-server] | Traceback (most recent call last): [sigul-server] | File "/usr/share/sigul/server.py", line 2815, in request_handling_child [sigul-server] | handler.handler(db, conn) [sigul-server] | File "/usr/share/sigul/server.py", line 1470, in cmd_new_key [sigul-server] | (pubkey, fingerprint, key_passphrase) = non_gnupg_new_key( [sigul-server] | File "/usr/share/sigul/server.py", line 1325, in non_gnupg_new_key [sigul-server] | key = crypto_rsa.generate_private_key( [sigul-server] | File "/usr/lib64/python3.9/site-packages/cryptography/hazmat/primitives/asymmetric/rsa.py", line 152, in generate_private_key [sigul-server] | _verify_rsa_parameters(public_exponent, key_size) [sigul-server] | File "/usr/lib64/python3.9/site-packages/cryptography/hazmat/primitives/asymmetric/rsa.py", line 163, in _verify_rsa_parameters [sigul-server] | if key_size < 512: [sigul-server] | TypeError: '<' not supported between instances of 'str' and 'int'
It looks like we're passing a string to an API that requires an integer.
I'm inclined to not bother fixing this in Sigul unless it's actively used by Fedora infra. @kevin, is this used currently? GPG and ECC key creation works, just RSA is broken.
Yeah, I don't think we do rsa keys any...