From 05c776e3df76e4f77228de64fbee88b7c65025f4 Mon Sep 17 00:00:00 2001
From: Vit Mojzis <vmojzis@redhat.com>
Date: Oct 31 2018 12:24:57 +0000
Subject: framework: catch exceptions caused by lookup_signature


A race condition can cause an attempt to search for signature which has
been removed by "prune". Handle such attempts correctly (without
crashing).

Resolves: rhbz#1636369, rhbz#1627908

---

diff --git a/framework/src/setroubleshoot/analyze.py b/framework/src/setroubleshoot/analyze.py
index ec865ee..2970507 100644
--- a/framework/src/setroubleshoot/analyze.py
+++ b/framework/src/setroubleshoot/analyze.py
@@ -434,7 +434,15 @@ class SETroubleshootDatabase(object):
     def delete_signature(self, sig, prune=False):
         log_debug("delete_signature: sig=%s" % sig)
 
-        siginfo = self.lookup_signature(sig)
+        try:
+            siginfo = self.lookup_signature(sig)
+        except ProgramError as e:
+            if e.errno == ERR_NO_SIGNATURE_MATCH:
+                log_debug("Signature not found!")
+                return
+            else:
+                raise
+
         self.sigs.remove_siginfo(siginfo)
         if self.notify:
             self.notify.signatures_updated('delete', siginfo.local_id)
@@ -448,14 +456,30 @@ class SETroubleshootDatabase(object):
     def evaluate_alert_filter(self, sig, username):
         log_debug("evaluate_alert_filter: username=%s sig=%s" % (username, sig))
 
-        siginfo = self.lookup_signature(sig)
+        try:
+            siginfo = self.lookup_signature(sig)
+        except ProgramError as e:
+            if e.errno == ERR_NO_SIGNATURE_MATCH:
+                log_debug("Signature not found!")
+                return "ignore"
+            else:
+                raise
+
         action = siginfo.evaluate_filter_for_user(username)
         return action
 
     def set_user_data(self, sig, username, item, data):
         log_debug("set_user_data: username=%s item=%s data=%s sig=\n%s" % (username, item, data, sig))
 
-        siginfo = self.lookup_signature(sig)
+        try:
+            siginfo = self.lookup_signature(sig)
+        except ProgramError as e:
+            if e.errno == ERR_NO_SIGNATURE_MATCH:
+                log_debug("Signature not found!")
+                return
+            else:
+                raise
+
         user_data = siginfo.get_user_data(username)
         user_data.update_item(item, data)
         self.modify_siginfo(siginfo)
@@ -463,7 +487,15 @@ class SETroubleshootDatabase(object):
     def set_filter(self, sig, username, filter_type, data = "" ):
         log_debug("set_filter: username=%s filter_type=%s sig=\n%s" % (username, filter_type, sig))
 
-        siginfo = self.lookup_signature(sig)
+        try:
+            siginfo = self.lookup_signature(sig)
+        except ProgramError as e:
+            if e.errno == ERR_NO_SIGNATURE_MATCH:
+                log_debug("Signature not found!")
+                return
+            else:
+                raise
+
         siginfo.update_user_filter(username, filter_type, data)
         self.modify_siginfo(siginfo)