#57 Please make spectool work on a list of spec files
Closed by decathorpe. Opened by nim.

So, I blew away my ~/rpmbuild/SOURCES to make sure no past leftover interfered with testing the new spectool, and now I need to re-populate it.

It would be awfully nice if spectool could operate on a list of spec files like rpmlint does. This way I could just do a:

$ rpmdev-spectool -R -g ~/fedora/*/*spec

instead of wrapping spectool in a shell loop


@nim Can you check whether this works for you? I'm using a different directory layout and don't want to mess things up locally.

https://pagure.io/fork/decathorpe/rpmdevtools/blob/master/f/rpmdev-spectool

decathorpe, https://pagure.io/fork/decathorpe/rpmdevtools/raw/master/f/rpmdev-spectool blows up on the second spec file

$  rpmdev-spectool -R -g ~/fedora/fedpkg/*-fonts/*spec
Downloading: http://arkandis.tuxfamily.org/fonts/Accanthis-Std-20101124.zip
100% of 409.1 KiB |####################################################################################################################################| Elapsed Time: 2:00:00 Time:  2:00:00
Downloaded: Accanthis-Std-20101124.zip
Downloading: http://arkandis.tuxfamily.org/docs/Accanthis-Cat.pdf
100% of 277.6 KiB |####################################################################################################################################| Elapsed Time: 0:00:00 Time:  0:00:00
Downloaded: Accanthis-Cat.pdf
error: Name field must be present in package: (main package)
error: Summary field must be present in package: (main package)
error: License field must be present in package: (main package)
Traceback (most recent call last):
  File "/usr/local/bin/rpmdev-spectool", line 426, in <module>
    exit(main())
  File "/usr/local/bin/rpmdev-spectool", line 352, in main
    spec = Spec(path)
  File "/usr/local/bin/rpmdev-spectool", line 207, in __init__
    self.spec = rpm.spec(self.path)
ValueError: can't parse specfile

Both the first and the second spec spectool fine separately

Can you try again? Made a small change that should fix this.

https://pagure.io/fork/decathorpe/rpmdevtools/blob/master/f/rpmdev-spectool

@decathorpe still blows up with the same trace :(

Well, then that's a limitation of the rpm python bindings. And if we need to create a subprocesses for parsing each .spec file then it's certainly easier to do this just with a loop in the shell instead.

Metadata Update from @decathorpe:
- Issue status updated to: Closed (was: Open)

Metadata