rpmdevtools

#15 spectool --get-files does not exit 1 when sources are 404 Not Found
Closed: Invalid Opened by derks.

Closed: Invalid
Reopen Issue

There is no indication of failure at all when running 'spectool --get-files' ... such as exiting 1 when one or more of the sources were not downloaded successfully. This makes it difficult to script around as... I would have to added a lot more logic to a) determine the source file name, and b) if that file was downloaded successfully.... where I should just be able to know from the exit code ($?) that spectool did not complete successfully.

{{{
[wdierkes@derks-linux git]$ spectool --get-files python-cement.spec
--2011-06-09 16:55:07-- http://builtoncement.org/cement/0.8/source/cement-0.8.16BAD.tar.gz
Resolving builtoncement.org... 67.23.43.60
Connecting to builtoncement.org|67.23.43.60|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2011-06-09 16:55:07 ERROR 404: Not Found.

[wdierkes@derks-linux git]$ echo $?
0
}}}

The output suggests that you're using an old version of spectool that uses wget for downloading. spectool in rpmdevtools >= 8.0 uses curl, and at least the current git version as well as the one in rpmdevtools 8.1 do return a non-zero exit status for 404's:

{{{
$ spectool -g foo.spec
Getting http://builtoncement.org/cement/0.8/source/cement-0.8.16BAD.tar.gz to ./cement-0.8.16BAD.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
$ echo $?
22
}}}
Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.