PR#34: Rework the CoreOS signer to handle ostree requests properly -

The ostree signing requests need to be handled differently. It required a refactoring to avoid cut-n-paste code.
Also, add some tests.

rebased onto e13f840899e777b2284a715141ab5dd93c01bcfd

Sep 13, 2019

@jlebon Could you have a look at this PR please? It was more changes than I thought initially but it should do what is necessary.

I'll add the emission of messages on completion in a following PR.

Thanks

Would it be cleaner to just have two separate commands? E.g. sign-coreos-artifact and sign-coreos-ostree ?

Checking hash for %s ?

This would belong well in a separate e.g. _verify_hash() function I think.

Just some minor comments, but LGTM overall!

rebased onto c4306d6476a5cc72c2a351a7e736a23b05cb4d4f

Sep 16, 2019

Alright, I made the changes, if you're still OK with it I'll merge it.

Pull-Request has been merged by abompard

Sep 16, 2019

Assignee

None

Tags

No Tags