#21 Create the directories while creating ostree ref if not exist
Merged by puiterwijk. Opened by sayanchowdhury.
sayanchowdhury/robosignatory create-ref-path  into  master

Download 21.patch

Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com

This should be fixing #19

thanks @sayanchowdhury ! @mohanboddu @kevin . This is fixing the the bug that has bit us several times in the past few releases. Please review.

Why are you using a separate if condition for this? We could just make sure to create the folder every time if refs are updated.

  • exist_ok is python3-only, while this currently runs on a python 2 server.

  • This creates the actual ref file as a directory, which is not going to work. Please add a basename() call to create the actual containing directory.

rebased onto 3c05d90a88d7e5dca6646918fd5f90225ffdaece

Please add a doref and to this so this directory only gets created if doref is enabled.

rebased onto f462fc2c81b7cad15acb2da630c69114b30ef3d9

@puiterwijk can you check if this looks good now?

Pull-Request has been merged by puiterwijk

Metadata