revisor

#65 isinstance() review

Closed: Fixed Opened May 3, 2007 by jsteffan.

We need to review the use of isinstance()

kanarip commented May 5, 2007

isinstance() is being used exactly the way it's supposed to:

test if the object variable you pass it (0) is actually an instance of the class (ref.) you pass it (1).

kanarip commented May 5, 2007

isinstance() is being used exactly the way it's supposed to:

test if the object variable you pass it (0) is actually an instance of the class (ref.) you pass it (1).

kanarip commented May 5, 2007

How can this be a blocker? Agreed unsuspected behaviour caused a fatal bug, but that ticket (#59) has been resolved. Downgrading Priority as we have only few days to get this fixed.

kanarip commented May 5, 2007

How can this be a blocker? Agreed unsuspected behaviour caused a fatal bug, but that ticket (#59) has been resolved. Downgrading Priority as we have only few days to get this fixed.

kanarip commented May 6, 2007

Moving ticket to another milestone due to lack of time

kanarip commented May 6, 2007

Moving ticket to another milestone due to lack of time

jsteffan commented May 7, 2007

package_selection.py line: 506 seems to not be working.

This causes the isinstance() test to fail.. and also causes check_options() to fail.

revisor just sits there doing nothing now.