This looks like a packaging issue because they are executable in the tarball

$(datadir) is what revisor seems to install them to, and this should not contain scripts. So yes, I assume the Fedora package (correctly) makes them non-executable, because rpmlint (correctly) complains otherwise.

So to me it seems that the bug is:
- revisor should not install these scripts in a data dir
- if it does, it should invoke them with a shell because it's not guaranteed they will remain executable

As revisor is a Fedora-specific project, the conventions and packaging guidelines matter, and this just goes to confirm my doubt that the actual revisor packages as shipped in Fedora get any testing. I think the devs of revisor exclusively test source tarballs and checkouts.

agreed, they should be in /usr/libexec

It is actually the autotools that are stripping the executable bit when make install is called.

I would normally agree with /usr/libexec, except that following changes in the nagios package has revealed that /usr/libexec doesn't seem to be in the FHS at all, which is why it was changed in that package.

Not sure what the guidelines say.

Ok, tested patch and it works though there are other errors you most likely filed. I'll take a look at those too.

I looked at HAL and the solution is to put the scripts in /usr/lib/revisor/scripts

attachment
0001-fix-non-executable-script-issue-by-installing-to-us.patch

Fixed in GIT, thanks for the patch