#324 confusing and probably unneeded use of globals in revisor/misc.py
Closed: Fixed Opened by thomasvs.

The top of the file has:
{{{
global yumobj, logger, pbar
}}}

Then there's def resolve_dependencies_ugly that has arguments with exactly the same name.

Either the global is wrong (I don't see any use of these symbols outside of their function scopes), or it's poor programming (and creates uncommented side effects). I suggest removing the global entirely.

In general, use of global indicates poorly thought out objects/methods, and makes code harder to follow and test.


Fixed in GIT, thanks

Metadata