Signed-off-by: Filip Valder fvalder@redhat.com
@ppisar Please for review & thanks in advance. /cc @jplesnik
Please wait, I found some issue with the validation of obsoletes -.yaml which I need to fix first, as this is to be different from the defaults validation.
Metadata Update from @ppisar: - Request assigned
This bug?
Obsoletes (tests): ================== nodejs:11 ERROR:root:Module name "perl" doesn't match filename "perl-5.30.yaml" Traceback (most recent call last): File "/home/petr/fedora-modules/fedora-module-defaults/./tests/validate.py", line 252, in <module> sys.exit(main()) File "/home/petr/fedora-modules/fedora-module-defaults/./tests/validate.py", line 234, in main idx_runtime.add_obsoletes(mmd) TypeError: Argument 1 does not allow None as a value
If you are going to keep checking for a file name and keep the stream in the file name, then use a colon as a separator (perl:5.30.yaml) rather than a hyphen. Hyphen is a valid character of a module and a stream, hence a-b-c.yaml based on a-b:c would clash with a file name based on a:b-c.
You can continue with rebasing this commit.
rebased onto dcdade7b8f28d99c36a0880093443b57e0939500
Should be ready for final...
rebased onto ccb5522d0bd4752964cc76048dea3d70951d0a6c
Pull-Request has been merged by ppisar
Merged into main branch for Fedora 36.
Did you know that Fedora 36 does not contain perl:5.30? I think we also should apply these changes to Fedora 35 which is the last Fedora with perl:5.30. And also to Fedora 34 which also contains perl:5.30.
Should I wait with backporting these changes until having a Fedora 36 compose and verifying it does not break anything? Please note that Fedora 36 undergoes a mass rebuild right now and that a compose process may be delayed or broken for few days or weeks for other reasons than this obsoletes change.
Signed-off-by: Filip Valder fvalder@redhat.com