#80 External checkin removed without error or warning
Closed: Invalid by adamwill. Opened by adamwill.

So I just noticed my mirror has not checked in for years, because q-f-m used to rely on external checkins (internal did not work), but then internal checkins were fixed and external checkin support removed, all apparently without any notification to the admin.

I think it would be nice if q-f-m would detect if the config file contains EXT_CHECKIN and either flat out die or at least generate a big fat warning that it doesn't work any more...


I'm not sure what coed you believe was removed. I don't think I did that intentionally. However, unless I'm failing to drive git properly, I don't see that there was ever any code referencing EXT_CHECKIN. git grep EXT_ $(git rev-list --all) shows nothing, as does git log -p --grep EXT_. However, I do see that you have an open pull request requesting functionality like that which I regrettably never addressed. Perhaps you have been assuming that it was merged?

Not so much 'assuming' as 'forgetting it was something I wrote and submitted in the first place' :P

Metadata Update from @adamwill:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

Metadata