quick-fedora-mirror

#67 Adding --delete to RSYNCOPTS makes fedora-buffer rsync fail
Closed: Invalid Opened by vedranm.

Closed: Invalid
Reopen Issue

Setting

RSYNCOPTS=(-aSH -f 'R .~tmp~' --stats --preallocate --delay-updates --delete --out-format='@ %i  %n%L')

results in

$ rsync -aSH -f 'R .~tmp~' --stats --preallocate --delay-updates --delete --out-format='@ %i  %n%L' --progress -v -v --files-from=filelist-transferlist --no-dirs --relative --compress rsync://d
l.fedoraproject.org/fedora-buffet/ /home/vedranm/fedoraproject                                                                                                                                                     
rsync: --delete does not work without --recursive (-r) or --dirs (-d).                                   
rsync error: syntax or usage error (code 1) at main.c(1567) [client=3.1.2]

while

RSYNCOPTS=(-rlptgoDSH -f 'R .~tmp~' --stats --preallocate --delay-updates --delete --out-format='@ %i  %n%L')

works fine, even though -a should be equivalent to -rlptgoD.

Is this a bug in rsync or the way quick-fedora-mirror uses it?

Well, first I'm not sure why you are explicitly adding --delete to RSYNCOPTS. What do you expect that to do which isn't done already by the default options?

I don't know why rsync gives that message. To be completely honest, the interaction of the various delay and delete options is rather complicated and I can't say I understand them all. What quick-fedora-mirror uses currently is what appears to work the best, and the 'R'isk entry for .~tmp~ is rather magical. If you're going to go modifying those arguments instead of adding something unrelated (like, I don't know, compression) then you really do need to have an understanding of how they go together, and while rsync's documentation is pretty good, you may still have to dig down to the source code.

I just can't see this is any sort of bug in quick-fedora-mirror, though.

Metadata Update from @tibbs:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.