#20 -n flag is still not working
Closed: Invalid Opened by brilong.

The "extra" parameter is not properly used inside do_rsync(). See -d 8 output below:

+./quick-fedora-mirror:503> extra=( )
+./quick-fedora-mirror:504> [[ -n 1 ]]
+./quick-fedora-mirror:505> extra+=( -n )
+./quick-fedora-mirror:507> do_rsync rsync://mirrors.rit.edu:874/fedora-buffet/ /var/www master-transferlist.sorted extra
+do_rsync:6> local 'src=rsync://mirrors.rit.edu:874/fedora-buffet/'
+do_rsync:7> local 'dest=/var/www'
+do_rsync:8> local 'files=master-transferlist.sorted'
+do_rsync:9> local 'opts=extra'
+do_rsync:10> local 'sleep=1'
+do_rsync:11> local 'log=rsync.log'
+do_rsync:12> local 'errlog=rsync-error.log'
+do_rsync:14> local -a verboseopts
+do_rsync:16> ((  VERBOSE >= 7  ))
+do_rsync:16> verboseopts+=( --progress )
+do_rsync:17> ((  VERBOSE >= 5  ))
+do_rsync:17> verboseopts+=( -v )
+do_rsync:18> ((  VERBOSE >= 4  ))
+do_rsync:18> verboseopts+=( -v )
+do_rsync:21> ((  VERBOSE <= 3  ))
+do_rsync:22> ((  VERBOSE == 0  ))
+do_rsync:24> flopts=( '--files-from=master-transferlist.sorted' )
+do_rsync:26> true
+do_rsync:34> ((  VERBOSE >= 5  ))
+do_rsync:35> db3 Calling /usr/bin/rsync -aSH -f 'R .~tmp~' --fuzzy --delay-updates --progress -v -v '--files-from=master-transferlist.sorted' -n rsync://mirrors.rit.edu:874/fedora-buffet/ /var/www
+db3:0> ((  VERBOSE >= 3  ))
+db3:0> echo '>>' Calling /usr/bin/rsync -aSH -f 'R .~tmp~' --fuzzy --delay-updates --progress -v -v '--files-from=master-transferlist.sorted' -n rsync://mirrors.rit.edu:874/fedora-buffet/ /var/www
Calling /usr/bin/rsync -aSH -f R .~tmp~ --fuzzy --delay-updates --progress -v -v --files-from=master-transferlist.sorted -n rsync://mirrors.rit.edu:874/fedora-buffet/ /var/www
+do_rsync:36> /usr/bin/rsync -aSH -f 'R .~tmp~' --fuzzy --delay-updates --progress -v -v '--files-from=master-transferlist.sorted' -n rsync://mirrors.rit.edu:874/fedora-buffet/ /var/www
opening tcp connection to mirrors.rit.edu port 874

I'm blind. Please close or delete this issue completely. Sorry for the noise.

Yeah, it still transfers the file lists; it just doesn't do the actual big transfer.

Metadata