#13 Don't sys.exit() from library function
Merged by praiskup. Opened by praiskup.
praiskup/prunerepo no-sys-exit-from-lib  into  main

Download 13.patch

Related to:
https://pagure.io/copr/copr/issue/1794
https://pagure.io/copr/copr/issue/1791

we should do

log.error(stderr.decode(encoding='utf-8'))

This will send the error sentence Error: Failed to download metadata for repo 'prunerepo_query': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried to log, not to stderr.

Otherwise LGTM, I've tried that in docker and the main process has shut down after prunerepo finished.

good idea

1 new commit added

  • Move the stderr output to log

2 new commits added

  • Move the stderr output to log
  • Don't sys.exit() from library function

We eventually decided to use just log.debug here.

Commit cc1def26 fixes this pull-request

Pull-Request has been merged by praiskup

Pull-Request has been merged by praiskup

This PR has been migrated to GitHub as a placeholder issue:
https://github.com/fedora-copr/prunerepo/issues/13

Metadata