#12 Faster srpm pairing with rpms
Merged by praiskup. Opened by praiskup.
praiskup/prunerepo faster-prunerepo-for-large-repos  into  main

Download 12.patch

Instead of parsing huge number of RPMs, use the DNF repodata.

Fix: #7

rebased onto 178b5c3767fb0396825793f64250ebabae72197c

Metadata Update from @praiskup:
- Pull-request tagged with: WIP

rebased onto 3d7e24237aefc18dd2cb8a238ac3e9bf2b3b1fe4

Metadata Update from @praiskup:
- Pull-request untagged with: WIP

rebased onto 8a99b07d02441e0f963431bccb666648a15e970f

1 new commit added

  • Bump release to beat the current Fedora releases

@frostyx , @schlupov can you please take a look? I'd like to wrap a new release as soon as possible.

1 new commit added

  • api: work with relative paths to the repo

for the /bin/prunerepo string

String?

Those are not supposed to be library calls.

The get_rpms_to_remove is supposed to be though. AFAIK.

5 new commits added

  • api: work with relative paths to the repo
  • Bump release to beat the current Fedora releases
  • Fix (or silence) the remaining PyLint warnings
  • Enhance the logging mechanism a bit
  • Faster srpm pairing with rpms

Thanks, yes ... s/string/command/, and I rephrased it a bit ... I wanted to claim that no one should ever import anything from that file.

Thanks, LGTM

Can we also expose the get_logger function? So I can call

log = get_logger(log_level="DEBUG")
rpms = get_rpms_to_remove(directory, log=log)

When I want to change the logging level in get_rpms_to_remove I need to copy all the code of the get_logger function to get the new logger with a different logging level.

The function name _np doesn't tell much about what the function does. Can we Instead call os.path.normpath? Or name the function get_normpath or to_normpath

I wanted to shorten the call, but I'll revert this part ...

I don't think it is a good idea ... if you mean in Copr, then there already is a log object that you can pass down into the call... can you elaborate on what you need this for?

rebased onto 3cf711f5045e68ecc66771daddf148ecf6edf2a2

I removed the _np shortcut.

Now I can't think of a project, I just came across it when I tried to use the get_rpms_to_remove. But it's not necessary, let's just leave it at that.

I removed the _np shortcut.

Thank you :)
+1

Pull-Request has been merged by praiskup

This PR has been migrated to GitHub as a placeholder issue:
https://github.com/fedora-copr/prunerepo/issues/12

Metadata