#54 Add support for close status
Merged by cverna. Opened by cverna.
cverna/pagure-importer fix_issue_status  into  master

Download 54.patch

Added support for the close status

Fixes #18

this will break github importer, since there is no close status there

we should default close_status to Fixed in case of github because, Closed as: None sounds weird like here: https://pagure.io/atomic-wg/issues?status=Closed

rebased

i think i didn't explain it properly. @cverna , according to current implementation even if the status is open, the close status will get the value as fixed for github importer. We should default the close status to None only and in the github importer, pass the close status as fixed if the status is closed.

Pagure ignores the close_status for open issues so, it could be ok to have it default to 'Fixed' (https://pagure.io/pagure/blob/master/f/pagure/templates/issues.html#_192)

But it would be nicer to manage the status in the github importer to be consistent with fedorahosted importer.

I ll make the changes :)

1 new commit added

  • Make close_status generic across importer

:thumbsup:

Pull-Request has been merged by cverna

Metadata