#130 Attachments for github importer
Merged by vivekanand1101. Opened by batman.
batman/pagure-importer gattach  into  master

Download 130.patch

tested here: https://stg.pagure.io/done/issue/8

It would be nice if we could have this automatically, maybe the user could have different flag like --namespace foobar. Then we could build the project name.

It is just a tought anyway :)

We will need an update to the README to ;)

it seems that this is not needed

maybe a comment to explain what we are looking for woulb be nice

Just wondering if getting the attachment should be in a separate function/method. It might be easier to maintain.

Got a few comments, but nothing big :). Going to test it later today

rebased

1 new commit added

  • Remove unused import base64

1 new commit added

  • Support for non-image file attachments

@cverna i changed a few things and added support for non-image files like pdf. Here is the issue that shows both working: https://stg.pagure.io/aaa/issue/54

1 new commit added

  • Add comments explaining regexes for image and non-image attachments

rebased

rebased

rebased

@cverna thank you

Pull-Request has been merged by vivekanand1101

Metadata