#127 Add --path option for github importer
Closed by vivekanand1101. Opened by batman.
batman/pagure-importer ind  into  master

Download 127.patch
no initial comment

We are using the tempfile.gettempdir() api to get the set the bare repo location. By default it is /tmp but this can be changed by using the following env variables TMPDIR, TEMP or TMP.

see documentation here

If we want to add this option to the cli maybe we can set this env variables ? or we might just want to update the README to specify this.

It would be better to do this in another PR on both github and fedorahosted.

sure

We are using the tempfile.gettempdir() api to get the set the bare repo location. By default it is /tmp but this can be changed by using the following env variables TMPDIR, TEMP or TMP.
see documentation here
If we want to add this option to the cli maybe we can set this env variables ? or we might just want to update the README to specify this.

This change is because of a confusion i had on what @pingou and @puiterwijk wanted. I thought they wanted to avoid pgimport doing clone and push by itself. After talking with @puiterwijk on irc, i came to know that they want to avoid pgimport doing any of the git operation by itself including making commits for each ticket. They want to have an option for workflow which would be something like this:
1. pgimport github --path (the importer should put all the tickets in the directory)
2. After the issues have been imported, the user will git init, git add, git commit and git push to correct remote.

rebased

So is this still needed ? I am confused the PR does not seems to do what you have described above.

So is this still needed ? I am confused the PR does not seems to do what you have described above.

It doesn't but, we will probably need --path although that one will be for a directory.

Then should we close this PR, and create a new one for the --path as directory ?

Pull-Request has been closed by vivekanand1101

Metadata