Signed-off-by: Clement Verna cverna@tutanota.com
:thumbsup:
This looks fine but I am still wonder if using an object is the simpler approach.
So :thumbsup: but I'd be up (as in I volunteer) to submit a PR making this all using methods instead of relying on objects if people are curious about what it would look like :)
Yeah I was thinking of the same but I think this PR is the first step, then we can have another PR where we remove the objects.
I think I ll make a release including this PR, then we can bring more changes. I have started working on threads to import the issues see #100. It took around 10 min to import the 6500ish issues from the rel-eng repo using 500 threads.
I still need to strengthen the code and manage exceptions inside the threads, but it looks promising :rotating_light:
Cool, let's go with this for the moment then :)
Thanks for the reviews ;)
Pull-Request has been merged by cverna
Signed-off-by: Clement Verna cverna@tutanota.com