pagure-dist-git

#6 Ship a custom repo_info template with information specific for dist-git
Merged by pingou. Opened by pingou.
expend_repo_info  into  master

Download 6.patch

This allows providing some Fedora specific information for this Fedora
specific instance of pagure.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Result: http://ambre.pingoured.fr/public/Pagure-DistGit.png

Depends on https://pagure.io/mdapi/pull-request/53

Go Bodhi go!

The hardcoded loopback IP address seems like it wouldn't work for users. Should this be a DNS name?

The code looks fine (though I suggest fixing that loopback address), but it seems like a lot of the template would be the same as the Pagure template code. Is there an opportunity to share template code (and JavaScript too) so that it's not repeating code between the projects?

LGTM.

The template basically comes from pagure, I just tweaked it a little to adjust it for dist-git. There has been thought about supporting a more proper theming approach than this override we're using here, but both @ryanlerch and I are missing the experience in this domain to know how to do this properly.
So currently, override the default template is our way to go :(

Actually hitting mdapi instead of my local dev instance sounds indeed appealing, let's try to do that :)

rebased

URL adjusted and tested locally, works fine.

Thanks for the review!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.