pagure-dist-git

#5 Adjust the generation of the configuration with the change made to groups
Merged by pingou. Opened by pingou.
fix_groups  into  master

Download 5.patch

This relies on https://pagure.io/pagure/pull-request/2403 which just
got merged and simplify how the configuration of groups is handled.

Fixes https://pagure.io/pagure-dist-git/issue/3
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

+1

LGTM, though it seems that there might not be tests on this function. I am assuming that since the tests weren't altered and it's return type changed. If that's true, I recommend writing test coverage for this function.

There are tests but it's testing the entire output not just this function that's why the output of the tests haven't changed while the output of this function did.

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.