I recommend documenting these params and the return value.
I recommend dropping this line.
I recommend moving this to the top of the file.
It would be good to put a docblock here describing the condition this test is checking.
It would be good to give this one a docblock too.
I notice that there are a lot of print statements here. I personally prefer to have the tests not print anything but it doesn't really matter. I'm just calling it out in case it wasn't intentional.
This code seems kinda similar to code in Pagure - is there an opportunity to share code here?
All comments are optional - LGTM!
It's actually the otherway around, I need to un-comment it, I had commented it out to debug something and forgot to revert it.
@ralph used this patter at first so I kept it there, I'll leave to call to him :)
It's overriding the code in pagure with some additional tweaks (calling to pdc, different permissions), so I'm not sure we can easily share more code
2 new commits added
Thanks for the review! :)
Pull-Request has been merged by pingou