#31 Atomic CI results integration in pagure itself
Merged by pingou. Opened by pingou.
atomic_ci_status  into  master

Download 31.patch
no initial comment

The commits will probably be easier to review if taken one by one :)

Screenshot, because they are always nice :)

pagure_commits_AtomicCi_vim.png

Looks cool to me, though it might be nice to have some tests to assert all the if statements in the new template code.

Also, Pagure is 100% the right place to report CI results instead of Bodhi!

Awesome addition!

I think it would be preferable to use split_message here, or maybe message_parts

Add some whitespace around the | operator?
{{ commitid | short }}

Whitespace around operator |, and maybe parentheses to clarify intent regarding operator precedence of | vs ==

in other places, there are spaces between tag content: {{ commit.parents[0].oid.hex }}

whitespace around |, maybe parentheses again

maybe extra whitespace {{ parent.oid.hex }}

missing whitespace for consistency {% endif %}

consistent whitespace around |, maybe parentheses

several whitespace inconsistencies in the following section, I didn't mark them all
they can obfuscate intent, e.g. {{'s' if diff|count > 1 }} could be {{ 's' if diff | (count > 1) }}

extra whitespace

Do we really want to continue the line here? If this is usually done in Pagure then ok, but I feel like this is something to avoid. You could just concatenate the strings.

1 new commit added

  • Adjust code style in the commits and commit templates

4 new commits added

  • Adjust code style in the commits and commit templates
  • Customize the commits.html template to show Atomic CI status
  • Customize the commit.html template to show Atomic CI status
  • Import the commit.html and commits.html templates from pagure

4 new commits added

  • Adjust code style in the commits and commit templates
  • Customize the commits.html template to show Atomic CI status
  • Customize the commit.html template to show Atomic CI status
  • Import the commit.html and commits.html templates from pagure

4 new commits added

  • Adjust code style in the commits and commit templates
  • Customize the commits.html template to show Atomic CI status
  • Customize the commit.html template to show Atomic CI status
  • Import the commit.html and commits.html templates from pagure

4 new commits added

  • Adjust code style in the commits and commit templates
  • Customize the commits.html template to show Atomic CI status
  • Customize the commit.html template to show Atomic CI status
  • Import the commit.html and commits.html templates from pagure

Looks good, and more consistent now. Thanks!

Thanks for the review! :)

Pull-Request has been merged by pingou

Metadata