pagure-dist-git

#126 Add a mechanism to tell that a branch is equal to another one when querying PDC
Merged by pingou. Opened by pingou.
override_branch  into  master

Download 126.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

This probably deserves some tests

rebased onto af0b2677e8ebb7c2d7406f66ec39bab25bf13101

rebased onto aedd9e0d43e29047a6876ec142abc3cfa79b0fd8

This needs to be on a per namespace feature

rebased onto a9226f1d66895e8e7be3a56b493e6dffb19380fe

I dont think PDC_BRANCH_OVERRIDES is set, it is being used in tests but I couldn't find it in the normal code base though.

Why checking in empty list?

It's set in the configuration file (of the pagure instance) there is nothing to set in pagure-dist-git

if branch_overrides.get(project.namespace) returns None that will break the if refname in part, so we do if branch_overrides.get(project.namespace) is None, use [] instead (cf the use of the () and or)

rebased onto c16e6f02d722a1ad7788af5efb03bfb34cfdfa69

In that case, its LGTM

Thanks for the review!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.