pagure-dist-git

#118 Add reason for orphaning package
Merged by pingou. Opened by zlopez.
zlopez/pagure-dist-git orphan  into  master

Download 118.patch

This PR implements https://pagure.io/pagure-dist-git/issue/112 and adds
following:

  • New API call to retrieve orphan status with reason
  • New Form for orphan reason
  • New table to record the reason
  • Removal of the reason when package is adopted

Signed-off-by: Michal Konečný mkonecny@redhat.com

rebased onto 57e75127b608e6445d6cee57bb92396e8c37cfb1

Just in case we ever need to store other reasons, let's call this one: orphan_reason.

rebased onto 960016e755c07138aa783814ca42734121d02fa4

@pingou: Should be fine now

1 new commit added

  • Update createdb.py with orphan reason table

Would be great to add the orphaning reason to the notify message

No problem, I will add it to the message.

1 new commit added

  • Add reason to notify message

I wonder if we shouldn't start documenting these endpoints as we do for the API endpoints in pagure itself. What do you think? (ie: provide the method + the input/output information)

I wonder if we shouldn't start documenting these endpoints as we do for the API endpoints in pagure itself. What do you think? (ie: provide the method + the input/output information)

:thumbsup:

I wonder if we shouldn't start documenting these endpoints as we do for the API endpoints in pagure itself. What do you think? (ie: provide the method + the input/output information)

I'm always for documenting things

rebased onto e3350403bf6eab1f1989b590e6bbc9ea94ec1e70

rebased onto cef698eb5df0ee2787c87a114012fedb0f752beb

This is the distgit namespace, so the url starts with /_dg/ not /api/0/ :)

Hm, the input isn't json it's a plain old HTML form. We could re-use the table-based layout that we use in pagure/api/repo.py for example

Thanks, wasn't sure about the namespace and none of the other API call is documented, so I looked at the pagure API for inspiration.

Will look at the repo.py layout.

rebased onto f7a1bc1cd94874f920884ed835141930876b2a42

Tests are passing a locally as well.

Looking great, thanks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.