packaging-committee

#883 Implement Golang Packaging Guidelines
Merged by ignatenkobrain. Opened by eclipseo.
eclipseo/packaging-committee implement_golang_guidelines  into  master

Download 883.patch

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

The current Go packaging guidelines have been in a draft state for several years
now, and they do not reflect the current practices from the Go SIG. As a result
of new RPM macros developed by Nicolas Mailhot, the Go SIG wishes to formally
adopt new Go Packaging Guidelines, with aims of automation, reliability and
simplicity.

Link to the Change proposal:
https://fedoraproject.org/wiki/Changes/Adopt_new_Go_Packaging_Guidelines

Easily read here: https://eclipseo.fedorapeople.org/guidelines/packaging-guidelines/Golang/

rebased onto 6c039372ef321052dec0dfc182375546e44c9d8c

Metadata Update from @ignatenkobrain:
- Request assigned

why is that there?

rebased onto 02a253b46799b4ed03baccd99e5fd2379a8f542a

rebased onto 670acfa0adc840586ec8f5ad475f50e29315a397

why is that there?

It is fixed to match the latest development.

rebased onto 1416e5d11cc2e9ff24a61ad162023c7986b09aed

rebased onto 70395e51524983e8f07b2868d8778a40e7a90a4a

rebased onto 19ddcf297f0ac92a44fd0fe2cb7797e3c5d3b321

rebased onto b29e3eb0a34c18dd76ca81cd9fc2ba138060aa36

format this with .... so that it renders as code block.

remove empty line

Probably you want to mention go2rpm?

Split line by semantic linebreak.

Some suspicious +

inter-document links are used with xref: please

code-block?

I think this deserves separate document in guidelines (or somewhere else). Which would apply for static libraries and Rust as well.

xref: please

So it looks more or less good with few exceptions:

  • %generate_buildrequires is not a thing yet. Please remove it remporarily and create PR to add it, we will merge it once that is landed in Fedora.
  • Use semantic breaks everywhere (see sembr.com on howto)

1 new commit added

  • Adressing Igor Gnatenko's comments

rebased onto 247fcee7ebdc5ec14bb473f1ddc0db0aeade9878

I still think the Security section is important and it's not mentioned anywhere in the Guidelines.

Yes, it is important.. But it should be generalized and moved to separate page. And can be referenced from Go guidelines.

Metadata Update from @churchyard:
- Pull-request tagged with: meeting

FESCo's approval of the Go packaging guidelines is conditional on FPC accepting the change. If FPC is ready to vote, can votes happen in the this PR so that I can proceed with processing this Change proposal?

FESCo's approval of the Go packaging guidelines is conditional on FPC accepting the change. If FPC is ready to vote, can votes happen in the this PR so that I can proceed with processing this Change proposal?

Vote already happened: https://pagure.io/packaging-committee/issue/382#comment-568599

It's approved, this need to be merged but I'm waiting on the Review of golist and go-rpm-macros, which is conditioned on an update of redhat-rpm-config.

@eclipseo thanks! I'll proceed with the change proposal as accepted.

Metadata Update from @ignatenkobrain:
- Request assignee reset

Metadata Update from @ignatenkobrain:
- Pull-request untagged with: meeting
- Pull-request tagged with: hasdraft

rebased onto 4d040f6339aba0b35ee1c80c0c5cf4de8f8fb5db

@eclipseo should we merge this in?

Metadata Update from @ignatenkobrain:
- Request assigned

I need to re-add the bits about auto BR and I want to add some precisions about cyclic dependencies. I'll try to do that tomorrow (19/06), I was doing review today.

rebased onto bdfffd216867e6eed28db6f630e2d698aca1268a

@eclipseo should we merge this in?

Ok I added what I needed, squashed the commit and it can now be merged.

Thanks!

Ok, let's merge this as is and deal with anything later.

Pull-Request has been merged by ignatenkobrain
Metadata
ignatenkobrain

hasdraft

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.