From 8193c85b4e9d0912d303223a39bc6fbd0b65999f Mon Sep 17 00:00:00 2001 From: Peter Oliver Date: Jan 09 2025 17:21:27 +0000 Subject: Create relative not absolute symlink to binary in Node.js example An absolute symlink causes a warning like the following: ``` RPM build warnings: absolute symlink: /usr/bin/tape -> /usr/lib/node_modules_20/tape/bin/tape ``` While we’re here, drop the `-f` option. If the target already exists, something has gone wrong. --- diff --git a/guidelines/modules/ROOT/pages/Node.js.adoc b/guidelines/modules/ROOT/pages/Node.js.adoc index 94c87d5..8128e66 100644 --- a/guidelines/modules/ROOT/pages/Node.js.adoc +++ b/guidelines/modules/ROOT/pages/Node.js.adoc @@ -349,7 +349,7 @@ cp -pr node_modules node_modules_prod \ mkdir -p %{buildroot}%{nodejs_sitelib}/tape/bin install -p -D -m0755 bin/tape %{buildroot}%{nodejs_sitelib}/tape/bin/tape mkdir -p %{buildroot}%{_bindir} -ln -sf %{nodejs_sitelib}/tape/bin/tape %{buildroot}%{_bindir}/tape +ln -sr %{nodejs_sitelib}/tape/bin/tape %{buildroot}%{_bindir}/tape %check %{__nodejs} -e 'require("./")'