From c41ffdb4df2fa146c88a6f533d3c85048279a8a6 Mon Sep 17 00:00:00 2001 From: Carl George Date: Aug 22 2024 16:19:56 +0000 Subject: Adjust phrasing for python3-devel build-time requirement The current guidelines could be misinterpreted to mean that a Python package must always have an explicit `BuildRequires: python3-devel` in the spec file. This change mentions this option in a bullet list alongside `%pyproject_buildrequires`. This also adds a specific mention that pulling in the build-time dependency transitively is not sufficient. This is a follow up to #1379. --- diff --git a/guidelines/modules/ROOT/pages/Python.adoc b/guidelines/modules/ROOT/pages/Python.adoc index cce0a8c..a949f67 100644 --- a/guidelines/modules/ROOT/pages/Python.adoc +++ b/guidelines/modules/ROOT/pages/Python.adoc @@ -100,16 +100,19 @@ if you need help or wish to help out. == Distro-wide guidelines -=== BuildRequire python3-devel +=== Build-time dependency on python3-devel -*Every* package that uses Python (at runtime and/or build time) +*Every* package that uses Python (at run-time and/or build-time) and/or installs Python modules -*MUST* explicitly BuildRequire `+python3-devel+`, -even if Python is not actually invoked during build time. -Such package *MUST* include `+BuildRequires: python3-devel+` in its `+.spec+` file -or use <> -in the `+%generate_buildrequires+` section. +*MUST* have a build-time dependency on `+python3-devel+`, +even if Python is not actually invoked during build-time. +Such a package *MUST* use one of the following in its `+.spec+` file: +* <> +in the `+%generate_buildrequires+` section +* `+BuildRequires: python3-devel+` + +Only having a transitive build-time dependency on `+python3-devel+` is not sufficient. If the package uses an alternate Python interpreter instead of `+python3+` (e.g. `+pypy+`, `+jython+`, `+python2.7+`), it *MAY* instead require the corresponding `+*-devel+` package.