From 6580b2b429662595a349a2a49804841b58763bf2 Mon Sep 17 00:00:00 2001 From: Miro Hrončok Date: Nov 15 2022 18:12:09 +0000 Subject: Don't say stable branches cannot do chain builds --- diff --git a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc index 74f6e2e..8935878 100644 --- a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc +++ b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc @@ -62,7 +62,8 @@ There are many many things to check for a review. This list is provided to assis It is often useful to submit a package for review along with its dependencies in separate tickets. As long as the submitter sets up the Depends on: and Blocks: fields in bugzilla properly, this is not an issue, and it is perfectly possible to review these packages before the full dependency chain is in the distribution (by maintaining a local repository, building and installing the packages locally, or maintaining a Copr). -However, please keep in mind that you cannot do koji builds if all of the build dependencies are not met (because you cannot provide additional dependencies to koji) and when the time comes to build these packages, they must be built in order and you must wait between builds for the dependencies to make it into the appropriate branch of the distribution. For the devel branch (Rawhide) this happens frequently and can be automated using chain builds, but for release branches each package must make it all the way to stable before the next package in the chain can be built. +However, please keep in mind that you cannot do koji builds if all of the build dependencies are not met (because you cannot provide additional dependencies to koji) and when the time comes to build these packages, they must be built in order and you must wait between builds for the dependencies to make it into the appropriate branch of the distribution. +This can be automated using side tags and chain builds. Please also note that while you may actually be able to build a package because all of its build-time dependencies are met, the package may still be non-installable (and thus useless) if its _runtime_ dependencies are not met. A package *MUST* not be built if any of its runtime dependencies are unsatisfied.