#263 Bundling exception request for nodejs-jshashes
Closed: Invalid Opened by tomh.

I currently have a review open for nodejs-jshashes (so I can use it to replace a bundled SHA1 implementation in nodejs-oauth) but nodejs-jshashes is in large part based on code copied from jshash. Relevant URLs:

nodejs-jshashes review: https://bugzilla.redhat.com/show_bug.cgi?id=919689
nodejs-oauth review: https://bugzilla.redhat.com/show_bug.cgi?id=914924
jsHashes source: https://github.com/h2non/jsHashes
jshash source: http://pajhome.org.uk/crypt/md5/scripts.html

The original jshash code has seemingly not been touched for three and a half years and consists of an independent implementation of each hash algorithm, presumably designed for use in browsers. Much of the code in each file is actually duplicated boilerplate that is common to all the files.

The jsHashes Node.js module has merged all the implementations together, removing the duplicate routines, corrected some esoteric choices in the original (like deciding not to pad base64 with "=" by default) and seems to be actively maintained and added exports to function as a Node.js module.

I would therefore like to request consideration of a bundling exception for nodejs-jshashes.


It turns out that nodejs-jshashes isnot actually required for nodejs-oauth on Fedora and it's likely it will never be needed as node's builtin crypto module is available on Fedora.

So I am closing this request.

Metadata