I'm traveling this weekend, but I can work with @admccartney on the next steps and sponsor him next week (unless somebody wants to beat me to it).

Okay, I'm back at home. @admccartney, if you could do some non-binding reviews of 2-3 different kinds of pending packages, that would be good way to show that you've understood the basics of the Fedora packaging guidelines and some domain-specific things (i.e. please don't just look at three Rust packages :wink: ).

The package review guidelines are outlined here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/

The "fedora-review" tool can help you do the checks that can be automated.

You can do reviews just as if they were "real" ones, except that you can't yet put the actual "stamp of approval" on any pending packages.

Once you're sponsored into the packager group, any non-binding approvals you made can be upgraded to actual approvals. But in my experience, pointing out issues that prevent packages from being approved in their current form are even more valuable, both to the "reviewer" and the "reviewee".

Feel free to continue with this on your own schedule, there is no time limit for the process. Just leave comments here with links to the package reviews on bugzilla that you took a look at, and I can help guide you through things if you have any questions.

Hi Fabio,

yeah I can do that no problem - think everything is pretty clear from your
email. Have quite a lot going on this week, so it will take me a little while to
get around to it. I'll post here as soon as I have something to report!

--
Adam McCartney - https://admccartney.mur.at
/

Hi Fabio,

got around to my first review today:
https://bugzilla.redhat.com/show_bug.cgi?id=2208353#c6

Thanks! I left some feedback. Sorry for the delay.

In the interest in getting things moving: If you do one more non-binding review (of a Rust package, since that's what you will be working on at first?), I will sponsor you into the packager group, and guide you through the next steps.

Thanks Fabio,

I'm taking a look at a few rust packages currently. Not sure if you'd classify this as a review:
https://bugzilla.redhat.com/show_bug.cgi?id=2272355

By the way, I think I may be using the wrong approach here. I'm running fedora-review to initiate a build and generate a template of a review. The man page seems to suggest that it's rather for "c/c++, R, Java and Perl".

Using fedora-review as a starting point is fine. I assume the man page was written (and last updated) before Rust was even a faint idea in Graydon Hoare's head ... so use fedora-review as a starting point, and then take a look whether the package satisfies Rust-specific guidelines.

Another question regarding the test environment, I guess it's recommended to test on rawhide?

https://bugzilla.redhat.com/show_bug.cgi?id=2283588#c2

I guess it's recommended to test on rawhide?

Yes. Packages are (almost) always added to Rawhide first, and then "merged" or "backported" to stable branches later, if needed.

https://bugzilla.redhat.com/show_bug.cgi?id=2283588#c2

This looks good to me, thanks! I'll leave a few followup comments on that bugzilla later.

For now, I'd say let's finally get you into the packager group.

Please go to https://accounts.fedoraproject.org and make sure you have signed the
Fedora Project Contributor Agreement, then I can add you to the "packager" group.

Please go to https://accounts.fedoraproject.org and make sure you have signed the
Fedora Project Contributor Agreement, then I can add you to the "packager" group.

Ok, should be good to go!

All done! You should be able to see the new group membership in your account:
https://accounts.fedoraproject.org/user/admccartney/

You will need to separately log in (or log out and back in) on https://src.fedoraproject.org/user/admccartney/groups for your group memberships to sync to the service that runs src.fedoraproject.org too.

If you have questions regarding the next steps (like importing your first package), let's talk on Matrix (#rust:fedoraproject.org or DM to @decathorpe:fedora.im both works for me).

All done! You should be able to see the new group membership in your account:
https://accounts.fedoraproject.org/user/admccartney/

You will need to separately log in (or log out and back in) on https://src.fedoraproject.org/user/admccartney/groups for your group memberships to sync to the service that runs src.fedoraproject.org too.

Yep, can see the group memberships now when I log in. Thanks for all your help!

If you have questions regarding the next steps (like importing your first package), let's talk on Matrix (#rust:fedoraproject.org or DM to @decathorpe:fedora.im both works for me).

Cool, I'll have a crack at it myself and see how far I get, will get in touch
when I need some advice.

--
Adam McCartney - https://admccartney.mur.at
/