modularity / modularity-tools

#31 Preparation for modtools package + tests
Merged by phracek. Opened by dhodovsk.
modularity/ dhodovsk/modularity-tools prepare-modtools  into  master

Download 31.patch

The pull request contains fixups for oc_template tests, modtools script and tests for rpm2module. Follow-up might include default openshift template for docker2openshift.

Since module_deps_differ.py is to be replaced by more valid dependency resolution script, it is not part of modtools.

please make this a path/to/Dockerfile

why python2? can we make it python3 by default and only (maybe in another PR)?

semver please, so likely 0.0.1

wow, integration test on cockpit's Dockerfile, that's brave!

Haven't tried it actually, changes look awesome! Nicely done, Dominika. Couple nits, one big thing -- python 3.

One more thing: can we set up CI? (I have no idea how to do that, I just saw a bunch of pagure projects having CI on jenkins)

2 new commits added

  • Fix documentation and version
  • Set python3 as default

Here is the issue for the CI: https://pagure.io/fedora-infrastructure/issue/6128

@dhodovsk Great.

I would prefer to have version 0.1. But sorry for digging.

I would like to test is, but have no idea how to do it on pagure. With GitHub it is really easy.

about the version comment, http://semver.org/ was required by ttomecek in trhe above comments

@dhodovsk go it. thnkx. Would it be possible to have setup.py with 775 permission?
I have checked it. And all works fine.
I would prefer to merge it.

I'm also +1 on merging and addressing potential issues individually.

Pull-Request has been merged by dhodovsk

Pull-Request has been merged by phracek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.